Fix crash when tapping on search icon on the Nearby screen #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6230
What changes did you make and why?
The override of the
isDarkTheme()method fromNearbyFilterSearchRecyclerViewAdapter.Callbackwas supposed to return theisDarkThemeproperty of theNearbyParentFragmentclass as it was doing in the java file.But in Kotlin syntax when we write
return isDarkTheme, we're actually calling the getter of the isDarkTheme property. But the getter is the isDarkTheme() method itself! This creates an infinite loop.So, I renamed the
isDarkThemeproperty.Tests performed (required)
Tested prodDebug on Samsung A14 with API level 34.
Screenshots (for UI changes only)
None