Fixes Issue 6308: Explore map shows image at my location rather than at shown location #6315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er Explore map behavior Before this commit, there was no way to tell if the user had arrived from the Nearby and before the Nearby map center location had been searched for markers. This commit adds a boolean flag to indicate this situation. Access, modification, and initialization methods were added for this boolean value. Additionally, a helper method to retrieve the Nearby map center LatLng was added as a convienience.
…tLng when appropriate Before this commit, when the user selected "Show in explore" in Nearby when no pins were on the map, Explore would only search for markers at the user's current GPS location, rather than those at the Nearby map center. After this commit, code was added to check if the user recently came from the Nearby map. If so, the stored coordinates of the Nearby map is searched rather than the user's current GPS coordinates. Additionally, the boolean that indicates that the user recently came from the Nearby map is set to false. This ensures that the stored Nearby map center coordinates are not used when the user taps the icon to focus the map on their current location.
|
✅ Generated APK variants! |
nicolas-raoul
approved these changes
May 21, 2025
sonalyadav1
pushed a commit
to sonalyadav1/apps-android-commons
that referenced
this pull request
May 22, 2025
…at shown location (commons-app#6315) * ExploreMapFragment.java: add helper methods and fields to enable proper Explore map behavior Before this commit, there was no way to tell if the user had arrived from the Nearby and before the Nearby map center location had been searched for markers. This commit adds a boolean flag to indicate this situation. Access, modification, and initialization methods were added for this boolean value. Additionally, a helper method to retrieve the Nearby map center LatLng was added as a convienience. * ExploreMapPresenter.java: fix map update code to search for Nearby LatLng when appropriate Before this commit, when the user selected "Show in explore" in Nearby when no pins were on the map, Explore would only search for markers at the user's current GPS location, rather than those at the Nearby map center. After this commit, code was added to check if the user recently came from the Nearby map. If so, the stored coordinates of the Nearby map is searched rather than the user's current GPS coordinates. Additionally, the boolean that indicates that the user recently came from the Nearby map is set to false. This ensures that the stored Nearby map center coordinates are not used when the user taps the icon to focus the map on their current location. --------- Co-authored-by: Nicolas Raoul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6308
What changes did you make and why?
The primary change I made was to
ExploreMapPresenter.updateMap(). In this method, a check was added to see if the user had selected "See in Explore" from Nearby recently. If so, the stored coordinates from Nearby is used to search for markers. If not, the user's GPS coordinates are used instead.A boolean flag
recentlyCameFromNearbyMapis used to prevent the Nearby map coordinates from being used again if the user presses the GPS button to focus on their current GPS location.Methods to simplify access and modification of data were also added.
Tests performed (required)
Tested ProdDebug on Android Studio Emulator with API level 36.
Screenshots (for UI changes only)
issue_6308_compress.webm