Skip to content

Conversation

amire80
Copy link
Collaborator

@amire80 amire80 commented Oct 10, 2025

Description (required)

Add a missing comma to the string nearby_search_hint.

There should be a comma before "etc." in a list,
and there already is a comma before "etc."
in the string depicts_search_text_hint, so it should be in this string to for consistency.

There should be a comma before "etc." in a list,
and there already is a comma before "etc."
in the string depicts_search_text_hint, so it should be
in this string to for consistency.
Copy link

✅ Generated APK variants!

@amire80
Copy link
Collaborator Author

amire80 commented Oct 10, 2025

... However, I'm not actually able to see it in the app. Where is it supposed to appear? I thought it's a placeholder in the search box in the Nearby view, but I don't see it. Am I misunderstanding something or is it a bug?

@nicolas-raoul
Copy link
Member

Any build error if you remove it?

@amire80
Copy link
Collaborator Author

amire80 commented Oct 11, 2025

It builds without problems. But if the message is not really seen, perhaps it should be fixed or removed.

@nicolas-raoul
Copy link
Member

any string that can be removed without breaking the build, should be removed I believe. Everything is used at build time, not run time, iirc.

@amire80
Copy link
Collaborator Author

amire80 commented Oct 11, 2025

Oh, sorry, I misunderstood—you were asking if it breaks the build if I remove the string entirely. I haven't tried that, and I don't think I should because it appears to be used in app/src/main/res/layout/filter_search_view_layout.xml. I'm just not able to make it actually show up when I open that screen, but it's quite possible that I'm doing it incorrectly.

@nicolas-raoul
Copy link
Member

Ah, understood! :-)

I cannot see it either. I believe it should be visible when tapping the Place type search icon in Nearby, but I see no hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants