Remove the string SingleWebViewActivity #6494
Open
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue commons-app#6492. Remove the title of a web activity and the accompanying string resource. This was not a real translatable message, but something that looks more like an identifier that shouldn't be translated. As far as I can tell, it's not seen anywhere in the interface because the actual title is set in the code that calls it.
|
✅ Generated APK variants! |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused string resource title_activity_single_web_view and its reference from the AndroidManifest.xml. The change eliminates what appears to be a non-translatable identifier string that was not actually displayed in the UI.
- Removed the unused string resource
title_activity_single_web_viewfrom strings.xml - Removed the label attribute reference from SingleWebViewActivity in AndroidManifest.xml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Removed the unused string resource for SingleWebViewActivity title |
| app/src/main/AndroidManifest.xml | Removed the label attribute reference to the deleted string resource |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Resolves issue #6492.
Remove the title of a web activity and the accompanying string resource.
This was not a real translatable message, but something that looks more like an identifier that shouldn't be translated. As far as I can tell, it's not seen anywhere in the interface because the actual title is set in the code that calls it.
Tests performed (required)
I ran it in the emulator, and the "Vanish account" function, which uses this activity, works as it worked before.