fix: allow touch down event to propagate to double tap gesture listener #6573
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
Collaborator
Author
|
Hi @nicolas-raoul, I created this PR to test if the fix doesn't break swipe gestures. I've tested on my end, and it works as expected. I'm looking forward to your review before we merge this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6571
What changes did you make and why?
We were consuming
MotionEvent.ACTION_DOWNby returning true from theGestureListenerinsideOnSwipeTouchListener, i.e., responsible for swiping behaviors. So, I make that listener return false so that touch event can be handled by other gesture listeners as well, likeDoubleTapGestureListener.Tests performed (required)
Tested ProdDebug on Samsung A14 with API level 35.
Screenshots (for UI changes only)
None