Refactor: Resolve TODOs in CommonsApplication and preserve UI settings on logout #6613
+25
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6612
Part of issue #6508
This PR addresses two long-standing
TODOitems inCommonsApplication.kt:Fresco Initialization Cleanup: Replaced the "band-aid"
try-catchblock during Fresco initialization with an explicit check for therobolectricenvironment. This prevents the app from attempting to load native libraries in test environments where they are unavailable, fulfilling theTODOfor test builds.Smart Preference Clearing: Fixed the "preference manager"
TODOby refactoringclearApplicationData. Instead of a total wipe usingclearAll(), the app now captures the user's Theme (KEY_THEME_VALUE) and App UI Language (APP_UI_LANGUAGE) preferences before clearing data, and restores them immediately after. This ensures that visual and accessibility preferences are persistent across logout/login sessions, improving user experience.Tests performed (required)
Tested prodDebug on Redmi Note 13 Pro 5g with API level 35.
./gradlew testpasses and that Fresco initialization is correctly skipped in the Robolectric environment.