Skip to content

Fix media attribution display in contributions and explore screens #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saicharan345 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Fix media attribution display in contributions and explore screens #6766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ an upload might take a dozen seconds. */
private fun setAuthorText(media: Media) {
binding.authorView.text = MediaAttributionUtil.getTagLine(media, itemView.context)
}

/**
* Checks if a media exists on the corresponding Wikipedia article Currently the check is made
* for the device's current language Wikipedia
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/fr/free/nrw/commons/explore/media/PagedMediaAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class PagedMediaAdapter(
.observeOn(AndroidSchedulers.mainThread())
.subscribe(
{ idAndLabels ->
media.creatorName = MediaAttributionUtil.getCreatorName(idAndLabels);
media.creatorName = MediaAttributionUtil.getCreatorName(idAndLabels)
holder.setAuthorText(media)
},
{ t: Throwable? -> Timber.e(t) })
Expand All @@ -83,6 +83,6 @@ class SearchImagesViewHolder(
}

fun setAuthorText(media: Media) {
binding.categoryImageAuthor.text = MediaAttributionUtil.getTagLine(media, containerView.context)
binding.categoryImageAuthor.text = MediaAttributionUtil.getTagLine(media, itemView.context)
}
}
Loading