move dbhelper to SupportSQLiteOpenHelper#6770
Open
rovertrack wants to merge 2 commits intocommons-app:mainfrom
Open
move dbhelper to SupportSQLiteOpenHelper#6770rovertrack wants to merge 2 commits intocommons-app:mainfrom
rovertrack wants to merge 2 commits intocommons-app:mainfrom
Conversation
psh
reviewed
Mar 21, 2026
Comment on lines
+33
to
+34
| .builder(TABLE_NAME).selection(selection, selectionArgs) | ||
| .columns(projection).selection(selection, selectionArgs) |
Collaborator
There was a problem hiding this comment.
You dont need to specify the selection() twice
Contributor
Author
There was a problem hiding this comment.
okay , done in latest commit
psh
reviewed
Mar 21, 2026
Comment on lines
+33
to
+34
| .builder(TABLE_NAME).selection(selection, selectionArgs) | ||
| .columns(projection).selection(selection, selectionArgs) |
Collaborator
There was a problem hiding this comment.
selection() is referenced twice
Contributor
Author
There was a problem hiding this comment.
okay , done in latest commit
psh
requested changes
Mar 21, 2026
Collaborator
psh
left a comment
psh
left a comment
There was a problem hiding this comment.
Just a couple of small things, overall, nice work.
Contributor
Author
thanks , was only possible because of your guidance ) |
|
✅ Generated APK variants! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #6769
relates to parent: #6768