ENH: Add JPEG2000 support#1406
Conversation
There was a problem hiding this comment.
Will you be updating the DCMTK build configuration in https://github.com/commontk/CTK/blob/master/CMakeExternals/DCMTK.cmake with the defined option for DCMTK_WITH_DCMJP2KCS? This being for folks or CI building CTK on its own with its defined external projects.
Yes, we could do that. It would serve as a simple example and test for DCMTKcs. I would just wait for the DCMTK/DCMTKcs implementation to be finalized - see if we need to fork DCMTK, or DCMTK upstream accepts our patch, etc. |
hjmjohnson
left a comment
There was a problem hiding this comment.
This looks correct as the first step.
|
Quick upstream-status check for reviewers — the DCMTK side of this story is settled. DCMTK upstream — what landed, what didn't
Implications for this PR
|
|
DCMTK has merged the OpenJPEG library patch today (that was needed to avoid CMake changes in projects that link DCMTK libraries) into their internal repository (see DCMTK/dcmtk#145 (comment)). Their github repository should be updated tomorrow and then I can finalize the changes (move DCMTKcs to the Slicer organization and then finalize merge all the pull requests) in the next few days. |
Requires DCMTK built with DCMTKcs JPG2K module.
5e3969c to
4b8ec0e
Compare
The change only has effect if CTK is used with DCMTK that is built with DCMTKcs JPG2K module.