Fix compile error for qt 5.8 #50
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In qt 5.8, two enum flags have been removed, so we need to delete them from the generated_cpp_56 source file. See discussion here: https://sourceforge.net/p/pythonqt/discussion/631393/thread/0bfe7e43/ I'm not sure if this is resolved in upstream svn or not.
|
This is not blocking RobotLocomotion/director#508. That PR can be merged while still referencing patmarion:fix-compile-error-on-qt5.8. |
That's why "blocking" was in quotes. It's not technically blocking, but having it would improve that PR. |
|
Well done. Thanks for the patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In qt 5.8, two enum flags have been removed, so we need to delete them from the generated_cpp_56 source file. See discussion here:
https://sourceforge.net/p/pythonqt/discussion/631393/thread/0bfe7e43/
This is "blocking" RobotLocomotion/director#508, so it would be nice if we can incorporate these changes into a CTK branch.