Upstream patches r445 to r455 #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Willing <[email protected]>
Closed
…up to 5.6.0) Signed-off-by: Christoph Willing <[email protected]>
|
Thanks 👍 Based on your work, I created https://github.com/commontk/PythonQt/commits/patched-8 and also made sure to give you credits for the last two commits. Could you add the additional changes updating the CMakeLists.txt on top of it ? |
|
Thanks for making the new branch. Based on that new branch, I needed to restore the inclusion of private include dirs in CMakeLists.txt. I wasn't sure how to add that to this pull request so I made a new one (#53) (and will close this one) |
thienhung1989
pushed a commit
to billow-vn/PythonQt
that referenced
this pull request
Dec 26, 2023
jcfr
pushed a commit
to jcfr/PythonQt
that referenced
this pull request
Jan 31, 2024
- closes commontk#52 (cherry picked from commit MeVisLab/pythonqt@8c371c0)
jcfr
pushed a commit
that referenced
this pull request
Jan 31, 2024
- closes #52 (cherry picked from commit MeVisLab/pythonqt@8c371c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches against patched-7 which contains up to r443.
Upstream r444 was not applied (considered a reversal) i.e. patched-7 already includes it.
Signed-off-by: Christoph Willing [email protected]