Skip to content

[ci] flatten caches#3999

Open
andresilva wants to merge 8 commits into
mainfrom
andre/ci-flatten-caches
Open

[ci] flatten caches#3999
andresilva wants to merge 8 commits into
mainfrom
andre/ci-flatten-caches

Conversation

@andresilva

Copy link
Copy Markdown
Member

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp d2ea0d7 Jun 10 2026, 11:05 AM

@andresilva andresilva force-pushed the andre/ci-flatten-caches branch from b45ce98 to b9a442a Compare June 9, 2026 17:19
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2ea0d7
Status: ✅  Deploy successful!
Preview URL: https://7b209dde.monorepo-eu0.pages.dev
Branch Preview URL: https://andre-ci-flatten-caches.monorepo-eu0.pages.dev

View logs

@andresilva andresilva force-pushed the andre/ci-flatten-caches branch from b9a442a to 4a81822 Compare June 9, 2026 17:20
@andresilva andresilva force-pushed the andre/ci-flatten-caches branch from 4a81822 to 5554901 Compare June 9, 2026 17:22
@andresilva andresilva requested a review from clabby June 9, 2026 17:23
@andresilva andresilva self-assigned this Jun 9, 2026
@andresilva andresilva moved this to Ready for Review in Tracker Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Benchmark results

Tip

PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.531 ms 1.523 ms -0.48% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.235 ms 3.234 ms -0.05% 10.00% ✅ PASS

Baseline commit(s): 5f84695ba100

@andresilva andresilva force-pushed the andre/ci-flatten-caches branch from 2acc285 to 9fb5b1e Compare June 9, 2026 18:37
@andresilva andresilva force-pushed the andre/ci-flatten-caches branch from 9fb5b1e to 6c4e8bd Compare June 9, 2026 18:43
@andresilva andresilva mentioned this pull request Jun 9, 2026
additional-toolchain: ${{ env.NIGHTLY_VERSION }}
additional-cache-key: ${{ matrix.flags || 'default' }}-part-${{ matrix.partition }}
additional-cache-key: ${{ matrix.flags || 'default' }}
rust-cache-save: ${{ matrix.partition == 1 }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that crates are largely shared by partitions? when I've poked around, I find they differ a decent bit? Maybe that is a fluke?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-cache is only caching dependencies, it doesn't cache anything from the workspace

clabby
clabby previously approved these changes Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (fcd0df9) to head (d2ea0d7).
⚠️ Report is 9 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3999      +/-   ##
==========================================
- Coverage   95.09%   95.08%   -0.02%     
==========================================
  Files         531      530       -1     
  Lines      217677   218478     +801     
  Branches     5292     5308      +16     
==========================================
+ Hits       206995   207733     +738     
- Misses       8890     8943      +53     
- Partials     1792     1802      +10     

see 69 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd0df9...d2ea0d7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants