Skip to content
This repository was archived by the owner on Jul 31, 2026. It is now read-only.

New author: Lumines - #784

Closed
danielkhmara wants to merge 1 commit into
community-archive:mainfrom
danielkhmara:main
Closed

New author: Lumines#784
danielkhmara wants to merge 1 commit into
community-archive:mainfrom
danielkhmara:main

Conversation

@danielkhmara

Copy link
Copy Markdown

Edited

Added

Checklist

@claremacrae claremacrae left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this pull request.

I am trying to understand why the author name was "wrong" in the first place.

The only PR on the obsidian-releases repo that I could find is this one:

And it says it is a new theme, rather than a transfer of ownership.

What am I missing?

@claremacrae

Copy link
Copy Markdown
Collaborator

These are the PRs that reference Lumines:

Lumines

Well, that's 5 minutes of my life that I not going to get back 🤣 😅

claremacrae added a commit to claremacrae/obsidian-hub that referenced this pull request Aug 23, 2025
This is being done to update the theme author from Avesend to danielkhmara

It replaces the edit in community-archive#784, which was giving a merge conflict due to changes in the number of download counts.

As a side effect, the script also generated details of the available Style Settings options.

(I couldn't safely push the conflict resolution to the author's branch in the PR, because the PR was created from the author's 'main' branch.)
claremacrae added a commit that referenced this pull request Aug 23, 2025
@claremacrae

Copy link
Copy Markdown
Collaborator

Thank you for the contribution @danielkhmara.

I was unable to work out how to cleanly resolve the merge conflict in the numbers of theme downloads, I think because the PR was created from your main instead of a branch.

So I ended up running the script to recreate the theme note from current data, and so happily it has the newest Style Settings features listed now.

Here is the alternative PR:

@claremacrae

Copy link
Copy Markdown
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants