Reduce Scaling Modifier for Drag & Drop Scroll Speed - #1139
Open
ryanknopf wants to merge 1 commit into
Open
Conversation
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1110 by reducing the scaling factor applied to drag-and-drop scrolling animation. This allows dragged elements to be more easily moved from one lane into an adjacent one off the edge of the screen without overshooting to max scroll position, especially on a touchscreen mobile device. Does not change the activation threshold distance from the frame edge for scrolling (35 pixels?) but effectively ramps scrolling speed 8x slower as the draggable element is moved closer to the frame edge.
Not tested on a mobile device. One theory as to why some users find this more bothersome than others. If a user is on a larger display resolution (4k, 1440p, etc) they may have display scaling active. In this case, the display scaling factor has the effect making the drag scrolling calculation more sensitive (larger pixel displacement of the element for the same physical mouse movement).