Fix: stop silently failing when failing to create new notes. fixes #1028 - #1188
Open
RobTheFiveNine wants to merge 1 commit into
Open
Fix: stop silently failing when failing to create new notes. fixes #1028#1188RobTheFiveNine wants to merge 1 commit into
RobTheFiveNine wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1028 by adding error handling around the creation of the new note. If an error occurs, it now no longer fails silently, and will display a message in Obsidian advising to try reducing the text length before creating a note (see screenshot below).
I noticed someone else has added a commit in another fork using Claude to try and address this, but that commit is invalid - it is doing an arbitrary check on the file name length, which won't work cross platform and won't work for ecryptfs file systems. The right way to do this is as has been done in this pull request (i.e. catching the file system error)