feat: fix CD disk detection; add manual folder picker #222
Conversation
undead2146
force-pushed
the
fix/cdiso-detection
branch
3 times, most recently
from
200d051 to
0bd3bb0
Compare
- Fixed game recognition for CD/ISO installations. - Added manual directory selection fallback. - Added missing Zero Hour retail paths. - Updated .gitignore for releases.
undead2146
force-pushed
the
fix/cdiso-detection
branch
from
0bd3bb0 to
3979893
Compare
| /// <param name="directory">The directory to check.</param> | ||
| /// <param name="executableNames">The list of executable names to look for.</param> | ||
| /// <returns>True if any of the executables exist.</returns> | ||
| private static bool HasAnyExecutable(string directory, string[] executableNames) |
There was a problem hiding this comment.
This whole method is basically just this, but much more verbose:
private static bool HasAnyExecutable(string directory, string[] executableNames) =>
executableNames.Any(exe => File.Exists(Path.Combine(directory, exe)));
Do you still need a separate method for it? I'd only do so if you use it in multiple places.
There was a problem hiding this comment.
I removed the method since it wasn't needed and just bloated more
| return installation; | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
This else block is entirely redundant as you are already doing a return from the if on line 1570. I think this could would make more sense / be more readable if the else block was removed.
There was a problem hiding this comment.
I moved it up now so it gets reached.
undead2146
left a comment
undead2146
left a comment
There was a problem hiding this comment.
Addressed the code review comments
| /// <param name="directory">The directory to check.</param> | ||
| /// <param name="executableNames">The list of executable names to look for.</param> | ||
| /// <returns>True if any of the executables exist.</returns> | ||
| private static bool HasAnyExecutable(string directory, string[] executableNames) |
There was a problem hiding this comment.
I removed the method since it wasn't needed and just bloated more
| return installation; | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
I moved it up now so it gets reached.
2 participants
This PR fixes the GameInstalation not being detected for CDISO whereby users do not have a
Instal Dirregistry entry.