-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add garmin-grafana LXC script #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks a lot for this script!
This seems like an awesome thing, I wanted to search something like this too.
this looks already pretty good, could you take a look at the marked things?
# Install python dependencies with uv | ||
$STD uv sync --locked --project /opt/garmin-grafana/ | ||
# Setup grafana provisioning configs | ||
# shellcheck disable=SC2016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# shellcheck disable=SC2016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following line needs to replace the string literal ${DS_GARMIN_STATS}
, so any parameter expansion should be prevented, therefore I have kept it in single quotes. This causes a warning from the linter though. I think it should be kept in to prevent future edits from accidentally causing parameter expansions here.
See this line in the source repo.
It's not the way I would have done it, but here we are :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter check exclusions are kept in the vscode config, like so
"shellcheck.exclude": [
"2164",
"1090",
"1091"
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this exclude the check across the entire repo? It would still be useful in other scripts, just not in this edge case
✍️ Description
Adds a new LXC container script for
garmin-grafana
. This is an application to locally display fitness metrics from Garmin Connect using InfluxDB and Grafana.🔗 Related PR / Issue
Link: N/A
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md
&CONTRIBUTING.md
guidelinesAppName.sh
,AppName-install.sh
,AppName.json
)