-
-
Notifications
You must be signed in to change notification settings - Fork 36
Added Support For Metabase Business Intelligence #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added Support For Metabase Business Intelligence - www.metabase.com
apt-get update &>/dev/null | ||
apt-get -y upgrade &>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use $STD
msg_info "Updating ${APP} LXC" | ||
apt-get update &>/dev/null | ||
apt-get -y upgrade &>/dev/null | ||
systemctl stop metabase.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.service not needed
APP="metabase" | ||
|
||
var_tags="metabase;dashboard;bi;analytics" | ||
var_disk="4" | ||
var_cpu="1" | ||
var_ram="512" | ||
var_os="debian" | ||
var_version="12" | ||
var_unprivileged=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle like in our other scripts: example: https://github.com/community-scripts/ProxmoxVE/blob/main/ct/streamlink-webui.sh#L9-L15
header_info | ||
echo -e "Loading..." | ||
APP="metabase" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove space
cat <<"EOF" | ||
| | | | | ||
_ __ ___ ___| |_ __ _| |__ __ _ ___ ___ | ||
| '_ ` _ \ / _ \ __/ _` | '_ \ / _` / __|/ _ \ | ||
| | | | | | __/ || (_| | |_) | (_| \__ \ __/ | ||
|_| |_| |_|\___|\__\__,_|_.__/ \__,_|___/\___| | ||
|
||
EOF | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handle like in our other scripts
msg_ok "Updated Successfully" | ||
msg_info "Waiting for metabase to start" | ||
while ! nc -z localhost 3000; do | ||
sleep 5 # wait for 5 seconds before check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
msg_ok "Updated Successfully" | ||
msg_info "Waiting for metabase to start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line between msg_ok and msg_info for better readability
msg_ok "Completed Successfully!\n" | ||
echo -e "Access http://${IP}:3000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use our default end headers like in ALL our other scripts.
apt-get update &>/dev/null | ||
apt-get -y upgrade &>/dev/null | ||
systemctl stop metabase.service | ||
METABASE_VERSION=`curl -s https://api.github.com/repos/metabase/metabase/releases/latest|awk -F \" -v RS="," '/tarball_url/ {print $(NF-1)}'|awk -F '/' '{print $NF}'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use $RELEASE like in our other scripts.
EOF | ||
} | ||
header_info | ||
echo -e "Loading..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Added Support For Metabase Business Intelligence - www.metabase.com
🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.
✍️ Description
Added Support For Metabase Business Intelligence - www.metabase.com
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md
&CONTRIBUTING.md
guidelinesAppName.sh
,AppName-install.sh
,AppName.json
)📋 Additional Information (optional)