Skip to content

Added Support For Metabase Business Intelligence #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cspnanda007
Copy link

Added Support For Metabase Business Intelligence - www.metabase.com

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.


✍️ Description

Added Support For Metabase Business Intelligence - www.metabase.com

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

Added Support For Metabase Business Intelligence - www.metabase.com
Comment on lines +43 to +44
apt-get update &>/dev/null
apt-get -y upgrade &>/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use $STD

msg_info "Updating ${APP} LXC"
apt-get update &>/dev/null
apt-get -y upgrade &>/dev/null
systemctl stop metabase.service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.service not needed

Comment on lines +21 to +29
APP="metabase"

var_tags="metabase;dashboard;bi;analytics"
var_disk="4"
var_cpu="1"
var_ram="512"
var_os="debian"
var_version="12"
var_unprivileged=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header_info
echo -e "Loading..."
APP="metabase"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space

Comment on lines +10 to +18
cat <<"EOF"
| | | |
_ __ ___ ___| |_ __ _| |__ __ _ ___ ___
| '_ ` _ \ / _ \ __/ _` | '_ \ / _` / __|/ _ \
| | | | | | __/ || (_| | |_) | (_| \__ \ __/
|_| |_| |_|\___|\__\__,_|_.__/ \__,_|___/\___|

EOF
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle like in our other scripts

msg_ok "Updated Successfully"
msg_info "Waiting for metabase to start"
while ! nc -z localhost 3000; do
sleep 5 # wait for 5 seconds before check again
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

Comment on lines +51 to +52
msg_ok "Updated Successfully"
msg_info "Waiting for metabase to start"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line between msg_ok and msg_info for better readability

Comment on lines +64 to +65
msg_ok "Completed Successfully!\n"
echo -e "Access http://${IP}:3000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use our default end headers like in ALL our other scripts.

apt-get update &>/dev/null
apt-get -y upgrade &>/dev/null
systemctl stop metabase.service
METABASE_VERSION=`curl -s https://api.github.com/repos/metabase/metabase/releases/latest|awk -F \" -v RS="," '/tarball_url/ {print $(NF-1)}'|awk -F '/' '{print $NF}'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use $RELEASE like in our other scripts.

EOF
}
header_info
echo -e "Loading..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants