Skip to content

Commit 1429133

Browse files
authored
Merge pull request #785 from companieshouse/IDVA52197
IDVA5-2197 Register an ACSP - Allow Previously Closed/ Ceased ACSPs to Access Registration Service
2 parents 83a1a17 + f55ce1f commit 1429133

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/services/transaction/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,6 @@ export interface TransactionData {
7575

7676
export interface Filing {
7777
status?: string;
78+
companyNumber?: string;
79+
type?: string;
7880
}

test/services/transaction/service.spec.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import sinon from "sinon";
33

44
import TransactionService from "../../../src/services/transaction/service";
55
import { RequestClient } from "../../../src/http";
6-
import { Transaction, TransactionData, TransactionList, TransactionResource } from "../../../src/services/transaction";
6+
import { Transaction, TransactionData, TransactionList, TransactionResource, Filing } from "../../../src/services/transaction";
77
import { ApiErrorResponse, ApiResponse } from "../../../src/services/resource";
88
import { Resource } from "../../../src";
99
const expect = chai.expect;
@@ -161,7 +161,14 @@ describe("transaction", () => {
161161
const itemsArray: TransactionData[] = ([
162162
{
163163
id: "123",
164-
status: "closed"
164+
status: "closed",
165+
filings: {
166+
testFiling: {
167+
status: "accepted",
168+
companyNumber: "AP000042",
169+
type: "acsp"
170+
} as Filing
171+
}
165172
}
166173
]);
167174

@@ -181,5 +188,6 @@ describe("transaction", () => {
181188
const castedData: Resource<TransactionList> = data as Resource<TransactionList>;
182189
expect(castedData.resource?.items[0].id).to.equal(transactionList.items[0].id);
183190
expect(castedData.resource?.items[0].status).to.equal(transactionList.items[0].status);
191+
expect(castedData.resource?.items[0].filings).to.equal(transactionList.items[0].filings);
184192
});
185193
});

0 commit comments

Comments
 (0)