Merge pull request #813 from companieshouse/feat/cc-2938/update-to-v24

chore/cc-2938: update sonar and project config options

Author: mwejuli-ch

package.json

@@ -3,6 +3,7 @@
     "version": "0.0.0",
     "main": "./dist/index.js",
     "types": "./dist/index.d.ts",
+    "type": "module",
     "files": [
         "dist"
     ],
@@ -53,7 +54,7 @@
         "nyc": "^15.1.0",
         "sinon": "^9.2.4",
         "sinon-chai": "~3.5.0",
-        "sonarqube-scanner": "^2.8.1",
+        "sonarqube-scanner": "^3.5.0",
         "ts-node": "9.1.1",
         "typescript": "4.1.6"
     },

sonar-project.properties

@@ -1,8 +1,7 @@
-sonar.projectKey=api-sdk-node
+sonar.projectKey=uk.gov.companieshouse:api-sdk-node
 
 sonar.host.url=${env.CODE_ANALYSIS_HOST_URL}
-sonar.login=${env.CODE_ANALYSIS_LOGIN}
-sonar.password=${env.CODE_ANALYSIS_PASSWORD}
+sonar.token=${env.CODE_ANALYSIS_TOKEN}
 
 sonar.sources=src
 sonar.tests=test