Address SonarQube Warnings in confirmation-statement-api #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses SonarQube warnings in the confirmation-statement-api project by improving code quality through refactoring and clean-up changes.
- Replaced deprecated APIs with modern equivalents
- Converted field injection to constructor injection for better testability
- Removed unused imports and variables to reduce code clutter
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Test files | Reorganized imports, removed unused exceptions, refactored variable names, and eliminated duplicated test logic |
| Service classes | Converted from field injection to constructor injection pattern |
| Interceptor classes | Added @SuppressWarnings annotations and converted to constructor injection |
| Controller classes | Converted to constructor injection and added missing path variables |
| Configuration classes | Removed redundant qualifiers and converted to constructor injection |
| Mapper classes | Updated to use modern Java stream API methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
feature/asm-776-address-sonarqube-warnings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address SonarQube Warnings in confirmation-statement-api
ASM-776
Type of change
Pull request checklist
An exhaustive list of peer review checks can be read here