Code improvements using Java records 2

[eedwards0]

Jira ticket: ASM-881

Brief description of the change(s)

Mini PR to cover changes to following classes and their usage:

- ExternalRejectEmailData

- ExternalRejectEmailModel

- InternalAvFailedEmailModel

- InternalAvFailedEmailData

Working example

Test notes

Regression

Checklist

• Adhered to the coding style guidelines.
  - [ ] Added/updated logging appropriately.
  - [ ] Written tests.
• Tested the new code in my local environment.
  - [ ] Updated Docker/ECS configs.
  ~~ - [ ] Added all new properties to chs-configs.~~
• Updated release notes. TODO

Strikethrough (~~like this~~) anything not applicable to your changes.

[ch-code-analysis]

CI: Security warnings found!

[chsonarqubeprchecks]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[Copilot]

Pull request overview

This PR converts several email-related classes from traditional Java classes to Java records, reducing boilerplate code and improving immutability. The changes migrate ExternalRejectEmailData, ExternalRejectEmailModel, InternalAvFailedEmailModel, and InternalAvFailedEmailData to records, along with ExternalAcceptEmailData. All associated tests and usages have been updated to use the new record accessor methods.

Key Changes:

• Converted 5 email model/data classes from traditional classes to Java records
• Updated all accessor method calls from getXxx() to the record-style xxx() pattern
• Added compact constructors to ensure immutability of list fields using List.copyOf()

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ExternalRejectEmailData.java	Converted from builder pattern class to record with immutable list handling
ExternalRejectEmailModel.java	Converted to record with defensive copying of reject reasons list
InternalAvFailedEmailData.java	Converted from builder pattern class to record with immutable list handling
InternalAvFailedEmailModel.java	Converted to record with defensive copying of infected files list
ExternalAcceptEmailData.java	Converted from builder pattern class to simple record
ExternalRejectEmailMapper.java	Updated to use record constructors and accessors, made fields final
InternalAvFailedEmailMapper.java	Updated to use record constructors and accessors, made fields final
ExternalAcceptEmailMapper.java	Updated to use record constructor instead of builder
EmailServiceImpl.java	Updated logging to use record accessors
FesServiceImplTest.java	Updated test assertions to use record accessors
ExternalRejectEmailDataTest.java	Updated test to construct record directly and use record accessors
ExternalRejectEmailMapperTest.java	Updated test to use record constructors and accessors, added final modifiers
InternalAVFailedEmailMapperTest.java	Updated test expectations to use record constructors
ExternalAcceptEmailMapperTest.java	Updated test to use record constructor, added final modifiers
EmailServiceImplTest.java	Updated tests to construct records directly and use record accessors

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ch-code-analysis]

CI: Security warnings found!

[PhilipGlover]

• have run and successfully reach confirmation
• code update look good
• mvn verify green, pipeline and Sonar pass
• most of the code changes are for emails which I haven't checked, since they depend on a response from CHIPS or AWS. This is only possible in cidev or Staging.
  Ought the Test notes as well as saying Regression required, to draw attention to Accept, Reject emails? I forget how to test the failed AV check.