Lp-468 Misc transaction utils to service refactor

[mattch1]

JIRA link

https://companieshouse.atlassian.net/browse/LP-468

Change description

Having deleted transaction utils, moved these methods to the transaction service:

• updateTransactionWithLinksAndPartnershipName
• hasExistingLimitedPartnership
• isTransactionLinkedToLimitedPartnership
• doesTransactionHaveALimitedPartnership
• isTransactionLinkedToLimitedPartnershipIncorporation
• isTransactionLinkedToPartner
• isForRegistration
• doChecks
• doIncorporationChecks
• isTransactionAndSelfLinkValid

This cause multiple test failures:
Moved transaction tests into:
src/test/java/uk/gov/companieshouse/limitedpartnershipsapi/service/TransactionServiceTest.java
from
src/test/java/uk/gov/companieshouse/limitedpartnershipsapi/service/LimitedPartnershipServiceTest.java

Test such as "givenDto_whenCreateLP_thenLPCreatedWithSubmissionIdAndTransactionUpdated" required some division into parts that were relevant to transaction and parts relevant to the partnership service.

Update service tests required changes.

Work checklist

• Bug fix
• New feature
• Breaking change
• Infrastructure change

Pull request checklist

• I have added unit tests for new code that I have added
• I have added/updated functional tests where appropriate
• The code follows our coding standards

An exhaustive list of peer review checks can be read here

Merge instructions

We are committed to keeping commit history clean, consistent and linear. To achieve this commit should be structured as follows:

<type>[optional scope]: <description>

and contain the following structural elements:

• fix: a commit that patches a bug in your codebase (this correlates with PATCH in semantic versioning),
• feat: a commit that introduces a new feature to the codebase (this correlates with MINOR in semantic versioning),
• BREAKING CHANGE: a commit that has a footer BREAKING CHANGE: introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,
• types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
• footers other than BREAKING CHANGE: <description> may be provided.

[ch-code-analysis]

CI: Security warnings found!

[chsonarqubeprchecks]

Quality Gate failed

Failed conditions
9 New issues

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[ch-code-analysis]

CI: Security warnings found!