pr comments - renamed basketitem to basket

Author: nabeelamirch

src/main/java/uk/gov/companieshouse/orders/api/controller/BasketController.java

@@ -55,9 +55,9 @@ public ResponseEntity<AddToBasketResponseDTO> addItemToBasket(final @Valid @Requ
             returnedBasket = basketService.saveBasket(mappedBasket);
         }
 
-        final AddToBasketResponseDTO basketItemDTO = mapper.basketToAddToBasketDTO(returnedBasket);
+        final AddToBasketResponseDTO addToBasketResponseDTO = mapper.basketToAddToBasketDTO(returnedBasket);
         trace("EXITING addItemToBasket() with " + addToBasketRequestDTO, requestId);
-        return ResponseEntity.status(HttpStatus.OK).body(basketItemDTO);
+        return ResponseEntity.status(HttpStatus.OK).body(addToBasketResponseDTO);
     }
 
     /**

src/test/java/uk/gov/companieshouse/orders/api/mapper/BasketMapperTest.java

@@ -36,7 +36,7 @@ static class Config {}
     private BasketMapper basketMapper;
 
     @Test
-    public void testAddToBasketItemDTOToBasket(){
+    public void testAddToBasketRequestDTOToBasket(){
         final AddToBasketRequestDTO dto = new AddToBasketRequestDTO();
         dto.setItemUri(ITEM_URI);
 
@@ -47,14 +47,14 @@ public void testAddToBasketItemDTOToBasket(){
     }
 
     @Test
-    public void testBasketItemToBasketItemDTO() {
+    public void testBasketToAddToBasketResponseDTO() {
         Basket basket = new Basket();
         Item item = new Item();
         item.setItemUri(ITEM_URI);
         basket.getData().setItems(Arrays.asList(item));
 
-        AddToBasketResponseDTO basketItemDTO = basketMapper.basketToAddToBasketDTO(basket);
+        AddToBasketResponseDTO addToBasketResponseDTO = basketMapper.basketToAddToBasketDTO(basket);
 
-        assertEquals(ITEM_URI, basketItemDTO.getItemUri());
+        assertEquals(ITEM_URI, addToBasketResponseDTO.getItemUri());
     }
 }

src/test/java/uk/gov/companieshouse/orders/api/service/BasketServiceTest.java

@@ -28,7 +28,7 @@ public class BasketServiceTest {
     private static final LocalDateTime CREATED_AT = LocalDateTime.of(2020, 01, 12, 9, 1);
 
     @Test
-    public void saveBasketItemPopulatesCreatedAtAndUpdatedAtAndSavesItem() {
+    public void saveBasketPopulatesCreatedAtAndUpdatedAtAndSavesItem() {
         final Basket basket = new Basket();
         basket.setId(ERIC_IDENTITY_VALUE);
 
@@ -49,7 +49,7 @@ public void saveBasketItemPopulatesCreatedAtAndUpdatedAtAndSavesItem() {
     }
 
     @Test
-    public void saveBasketItemPopulatesUpdatedAtAndSavesItem() {
+    public void saveBasketPopulatesUpdatedAtAndSavesItem() {
         final Basket basket = new Basket();
         basket.setCreatedAt(CREATED_AT);
         basket.setId(ERIC_IDENTITY_VALUE);