Fix version prefix detection for libraries without v-prefix - #7
Merged
Conversation
The check_github_release_exists function was incorrectly checking both with and without 'v' prefix, causing false positives when determining if a specific tag format exists. This led to incorrect target_prefix generation for libraries like FusedKernelLibrary that don't use 'v' prefixes in their tags. Changes: - Modified check_github_release_exists to only check the exact version - Added check_git_tag_with_fallback for user-friendly version detection - Preserved the smart auto-detection feature for user convenience This fixes the issue where libraries without 'v' prefix were incorrectly getting target_prefix: v in their configuration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_prefix: vgeneration for libraries that don't use 'v' prefixes in their tagsProblem
The ce-library-wizard was incorrectly generating
target_prefix: vfor libraries like FusedKernelLibrary that use tags likeBeta-0.1.9without any 'v' prefix. This was reported in compiler-explorer/infra#1755Root Cause
The
check_github_release_existsfunction was checking both with and without 'v' prefix when validating a specific tag. When checking ifvBeta-0.1.9exists, it would also checkBeta-0.1.9, find it exists, and incorrectly return true.Solution
check_github_release_existsto only check the exact version specifiedcheck_git_tag_with_fallbackfunction for cases where we want user-friendly fallback behavior1.0.0and it will correctly detect if the repo usesv1.0.0Test Results
🤖 Generated with Claude Code