Skip to content

fix addressof for LowLevelView when they are nullptr #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vipul-Cariappa merged 1 commit into from
Nov 26, 2025
Merged

fix addressof for LowLevelView when they are nullptr #142

Vipul-Cariappa merged 1 commit into from
Nov 26, 2025

Conversation

@Vipul-Cariappa
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa commented Nov 26, 2025

Needs test:

import cppyy
from cppyy import gbl

cppyy.cppdef(r"""
namespace LLV {
int x = 10;
int *ptr_x = &x;
int *ptr_null = nullptr;
}
""")

assert cppyy.addressof(gbl.LLV.ptr_x)
assert cppyy.addressof(gbl.LLV.ptr_null) == 0

@Vipul-Cariappa Vipul-Cariappa mentioned this pull request Nov 26, 2025
Open
vgvassilev
vgvassilev reviewed Nov 26, 2025
View reviewed changes
Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance of adding a test?

@Vipul-Cariappa
Copy link
Collaborator Author

Vipul-Cariappa commented Nov 26, 2025

Tests go to cppyy repo. Will add soon.

Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Nov 26, 2025
@Vipul-Cariappa
Add missing tests
465fb20 
for the following fixes/features
- compiler-research/CPyCppyy#135
- compiler-research/CPyCppyy#137
- compiler-research/CPyCppyy#142
@Vipul-Cariappa Vipul-Cariappa mentioned this pull request Nov 26, 2025
Open
vgvassilev
vgvassilev approved these changes Nov 26, 2025
View reviewed changes
Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vipul-Cariappa Vipul-Cariappa merged commit 8757c17 into compiler-research:master Nov 26, 2025
34 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the dev/addressof-LowLevelView branch November 26, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@aaronj0 aaronj0 Awaiting requested review from aaronj0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vipul-Cariappa @vgvassilev