Skip to content

Removed redundant installation of tagfiles in lite #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kr-2003
Copy link
Contributor

@kr-2003 kr-2003 commented May 6, 2025

Fixes #267
Screenshot 2025-05-06 at 8 24 34 PM
Screenshot 2025-05-06 at 8 25 39 PM

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (9e2abcb) to head (df6106a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Hey @kr-2003,

Would need some help !

Could you please try all the inline documentation use cases mentioned here (https://xeus-cling.readthedocs.io/en/latest/inline_help.html)

There are 3 sections I suppose. These are xeus-cling docs, we need to see if everything works for lite. If yes, we need to update xeus-cpp's documentation to also add the same.

@kr-2003
Copy link
Contributor Author

kr-2003 commented May 20, 2025

Could you please try all the inline documentation use cases mentioned here (https://xeus-cling.readthedocs.io/en/latest/inline_help.html)

I have tried for std::vector and xt::xtensor. It works fine for st::vector.

Screenshot 2025-05-20 at 12 41 32 PM

To enable documentation for third-party libs, we need to follow these steps.

@anutosh491
Copy link
Collaborator

Okay let's try it out .

Getting and using xtensor with xeus-cpp-lite would only require it to be a part of the host prefix (as header only)

  1. So please fetch it from emscripten-forge and try a clean build

image

  1. Then try supporting the xtensor usecase.

@kr-2003
Copy link
Contributor Author

kr-2003 commented May 20, 2025

I have added xtensor tagfiles.
Screenshot 2025-05-20 at 2 59 11 PM

@anutosh491
Copy link
Collaborator

I have added xtensor tagfiles.

Ohh the xtensor based files are also being preloaded and not being picked up from the prefix correct ?

@kr-2003
Copy link
Contributor Author

kr-2003 commented May 20, 2025

I have added xtensor tagfiles.

Ohh the xtensor based files are also being preloaded and not being picked up from the prefix correct ?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation of tagfiles for lite
3 participants