Skip to content

feat: implement AsFd trait for many types#395

Merged
Berrysoft merged 1 commit into
compio-rs:masterfrom
Sherlock-Holo:fd_trait
May 2, 2025
Merged

feat: implement AsFd trait for many types#395
Berrysoft merged 1 commit into
compio-rs:masterfrom
Sherlock-Holo:fd_trait

Conversation

@Sherlock-Holo
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft
Copy link
Copy Markdown
Member

Also implement for AsHandle & AsSocket?

@Sherlock-Holo
Copy link
Copy Markdown
Contributor Author

Sherlock-Holo commented May 1, 2025

Also implement for AsHandle & AsSocket?

done, but AsHandle is not implemented by Socket2, so I only can implement AsSocket in macro

@Sherlock-Holo Sherlock-Holo force-pushed the fd_trait branch 2 times, most recently from ec26471 to 8da1ce4 Compare May 1, 2025 14:15
@Berrysoft Berrysoft merged commit da9daba into compio-rs:master May 2, 2025
51 checks passed
@Sherlock-Holo Sherlock-Holo deleted the fd_trait branch May 10, 2025 11:06
George-Miao pushed a commit to George-Miao/compio that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants