Skip to content

perf(driver): set setup_coop_taskrun for io-uring #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Berrysoft merged 2 commits into from
May 10, 2025
Merged

perf(driver): set setup_coop_taskrun for io-uring #401

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffabe41
perf(driver): set setup_coop_taskrun for io-uring
Sherlock-Holo May 10, 2025
8358a58
feat(driver): allow user to choose enable coop_taskrun and taskrun_fl…
Sherlock-Holo May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions compio-driver/src/iour/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,21 @@ impl Driver {
trace!("new iour driver");
let notifier = Notifier::new()?;
let mut io_uring_builder = IoUring::builder();
if let Some(sqpoll_idle) = builder.sqpoll_idle {
io_uring_builder.setup_sqpoll(sqpoll_idle.as_millis() as _);

match builder.sqpoll_idle {
Some(sqpoll_idle) => {
io_uring_builder.setup_sqpoll(sqpoll_idle.as_millis() as _);
}

None => {
Comment thread
Sherlock-Holo marked this conversation as resolved.
Outdated
// Available since Linux Kernel 5.19. This will optimize performance for most
// cases, especially compio is a single thread runtime
// However, it can't run with sqpoll feature
io_uring_builder.setup_coop_taskrun();
io_uring_builder.setup_taskrun_flag();
}
}

let mut inner = io_uring_builder.build(builder.capacity)?;
#[allow(clippy::useless_conversion)]
unsafe {
Expand Down
Loading