Skip to content

chore(ci): remove setup for aws-lc-fips-sys#527

Merged
Berrysoft merged 3 commits into
compio-rs:masterfrom
AsakuraMizu:ci-cleanup
Nov 18, 2025
Merged

chore(ci): remove setup for aws-lc-fips-sys#527
Berrysoft merged 3 commits into
compio-rs:masterfrom
AsakuraMizu:ci-cleanup

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Collaborator

These were introduced in #333 to support aws-lc-rs. Since aws-lc-rs was removed in #521, they are now useless.

@AsakuraMizu
Copy link
Copy Markdown
Collaborator Author

I noticed that currently -Z minimal-versions doesn't actually do anything. We should use cargo-minimal-versions instead. However, it is not working at the moment due to the feature selection issue with compio-driver (cargo-minimal-versions depends on cargo-hack, which builds each subcrate independently.).

@George-Miao
Copy link
Copy Markdown
Member

I noticed that currently -Z minimal-versions doesn't actually do anything.

Hmm. Can you explain more?

@Berrysoft
Copy link
Copy Markdown
Member

it is not working at the moment due to the feature selection issue with compio-driver

Let's wait for #528 then?

@George-Miao
Copy link
Copy Markdown
Member

Can you also remove the relevant env variable in flake.nix?

@AsakuraMizu
Copy link
Copy Markdown
Collaborator Author

I noticed that currently -Z minimal-versions doesn't actually do anything.

Hmm. Can you explain more?

See https://github.com/taiki-e/cargo-minimal-versions#details. cargo update -Z minimal-versions needs to be executed before actual check. And this is the expected behavior:

图片

Copy link
Copy Markdown
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft
Copy link
Copy Markdown
Member

We should use cargo-minimal-versions instead.

Sounds reasonable. Feel free to create a PR for that if you're interested in.

@Berrysoft Berrysoft merged commit 9fbd9f6 into compio-rs:master Nov 18, 2025
50 checks passed
@George-Miao George-Miao mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants