feat(net): incoming stream#759
Merged
Merged
Conversation
10 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “incoming connection stream” API to compio-net listeners so callers can iterate over accepted connections as a futures_util::Stream, with per-connection SocketOpts support.
Changes:
- Add
TcpListener::incoming*andUnixListener::incoming*returningStreams of accepted connections. - Implement an internal
Socket::incoming()stream (Incoming) with platform-specific accept logic (AcceptMulti on Unix, state machine on Windows). - Add a TCP-focused integration test and promote
futures-utilto a normal dependency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-net/tests/incoming.rs | New integration test for TcpListener::incoming() |
| compio-net/src/unix.rs | Add UnixListener::incoming* + UnixIncoming stream wrapper applying SocketOpts |
| compio-net/src/tcp.rs | Add TcpListener::incoming* + TcpIncoming stream wrapper applying SocketOpts |
| compio-net/src/socket.rs | Add internal Incoming accept stream and Socket::incoming() constructor |
| compio-net/Cargo.toml | Add futures-util as a non-dev dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
George-Miao
reviewed
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.