feat(driver,net)!: reuse socket on Windows#887
Merged
Conversation
Berrysoft
added
package: net
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows-only support for reusing TCP/Unix socket handles by introducing a disconnect operation (backed by DisconnectEx(TF_REUSE_SOCKET)) and plumbed APIs to accept/connect using a provided socket.
Changes:
- Add Windows-only
disconnect+accept_withAPIs forTcpStream/TcpListenerandUnixStream/UnixListener. - Extend the IOCP
Acceptop to accept a caller-provided accept socket, and add a new IOCPDisconnectop. - Add Windows-only TCP tests for disconnect + reuse.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-net/tests/tcp_disconnect.rs | Adds Windows tests for TCP disconnect + socket reuse. |
| compio-net/src/unix.rs | Adds Windows-only accept_with and disconnect for Unix domain sockets. |
| compio-net/src/tcp.rs | Adds Windows-only accept_with and disconnect for TCP, plus a Windows connect note. |
| compio-net/src/socket/mod.rs | Wires Socket::disconnect and Socket::accept_with on Windows; broadens AsFd impl usage. |
| compio-net/src/incoming/windows.rs | Updates Accept generic parameters for the new IOCP Accept signature. |
| compio-driver/src/sys/op/socket/iocp.rs | Makes IOCP Accept accept a generic accept-socket and adds IOCP Disconnect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Berrysoft
force-pushed
the
dev/iocp-socket-reuse
branch
from
e535470 to
264082a
Compare
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge it before #885 .
This PR adds
disconnectfor sockets, but only on Windows.