fix(bench): avoid testing allocations#905
Merged
Merged
Conversation
fantix
approved these changes
May 4, 2026
Collaborator
fantix
left a comment
fantix
left a comment
There was a problem hiding this comment.
Clean fix in general 👍 only a question inline.
Also, now that the buffer size is larger, we may want to avoid repeated 512KB allocations during setup for hygiene purposes, but this is trivial and irrelevant to the benchmark itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed all possible allocations out of the benchmark region, and enlarged the buffer.