Skip to content

feat(io)!: use shared ref in *_at#907

Merged
Berrysoft merged 1 commit into
compio-rs:masterfrom
Berrysoft:shared-read-to-string-at
May 4, 2026
Merged

feat(io)!: use shared ref in *_at#907
Berrysoft merged 1 commit into
compio-rs:masterfrom
Berrysoft:shared-read-to-string-at

Conversation

@Berrysoft
Copy link
Copy Markdown
Member

I don't know why we required &mut in read_to_string_at before... It's just... I think we should make it consistent.

@Berrysoft Berrysoft added the package: io Related to compio-io label May 4, 2026
@Berrysoft Berrysoft self-assigned this May 4, 2026
@Berrysoft Berrysoft requested review from George-Miao and fantix May 4, 2026 14:44
@github-actions github-actions Bot added breaking change enhancement New feature or request labels May 4, 2026
Copy link
Copy Markdown
Collaborator

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we required &mut in read_to_string_at before...

Seems to be a muscle memory issue in #413 where the AsyncReadExt was mostly using &mut while AsyncReadAtExt wasn't.

@Berrysoft
Copy link
Copy Markdown
Member Author

AsyncReadExt uses &mut because it modifies the internal cursor, while AsyncReadAtExt doesn't.

@Berrysoft Berrysoft merged commit d418e5f into compio-rs:master May 4, 2026
72 of 75 checks passed
@Berrysoft Berrysoft deleted the shared-read-to-string-at branch May 4, 2026 15:07
@github-actions github-actions Bot mentioned this pull request May 4, 2026
@github-actions github-actions Bot mentioned this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change enhancement New feature or request package: io Related to compio-io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants