Skip to content

feat(executor): implement std::io::Error conversion for JoinError #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Berrysoft merged 1 commit into from
May 13, 2026
Merged

feat(executor): implement std::io::Error conversion for JoinError #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions compio-executor/src/join_handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::{
error::Error,
fmt::Display,
io,
marker::PhantomData,
mem::ManuallyDrop,
panic::resume_unwind,
Expand Down Expand Up @@ -104,6 +105,15 @@ impl Display for JoinError {

impl Error for JoinError {}

impl From<JoinError> for io::Error {
fn from(e: JoinError) -> Self {
match e {
JoinError::Cancelled => io::Error::other("Task was cancelled"),
JoinError::Panicked(_) => io::Error::other("Task has panicked"),
}
}
}

impl<T> Future for JoinHandle<T> {
type Output = Result<T, JoinError>;

Expand Down
Loading