perf: improve websockets performance#68
Merged
Merged
Conversation
Fixes the problem of the underlying buffer getting zeroed out twice. It now happens only once and is done by the tungstenite crate. We use that information to avoid redoing the same work.
abh1nav10
force-pushed
the
optimize-websockets
branch
from
July 21, 2026 14:17
552d7a3 to
b707de8
Compare
Berrysoft
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
cyper-axumwebsockets performance by a significant margin by avoiding zeroing out an already zeroed out buffer.Addresses #66, in which further improvements after this can be made only upon using
io::Read::read_bufwhich means that it probably closes the issue asread_bufstabilization issue does not belong here.Also addresses #53.