feat(notify): move from compio-runtime#10
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new notify synchronization primitive to this crate (intended to replace the dependency/usage from compio-runtime) and exposes it under both sync and unsync namespaces behind a feature flag.
Changes:
- Introduce
src/notify.rswithsync/unsyncimplementations of a one-shot notifier + handle. - Wire the new
notifymodule intosrc/lib.rsand add anotifyfeature inCargo.toml. - Derive
DebugforFlag(used by the new notifier’s debug derives).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/notify.rs |
New notifier implementation for both sync and unsync variants. |
src/lib.rs |
Feature-gated module include and re-exports for sync::notify / unsync::notify. |
src/flag.rs |
Add Debug derive to support debug output of notifier internals. |
Cargo.toml |
Add notify feature (depends on waker_slot). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
I will able to choose the exact (sync or unsync) version of |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
George-Miao
reviewed
Feb 23, 2026
Member
Author
|
Could you publish a new release? |
George-Miao
pushed a commit
to George-Miao/synchrony
that referenced
this pull request
Feb 24, 2026
* feat(notify): spsc notifier * docs(notify): fix old names * fix(notify): apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(notify): rename to AsyncFlag --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.