feat: replace futures crate with futures-util#6
Conversation
|
Hm, what's the difference? |
Less dependencies, I think? |
|
futures-util is smaller, I think. |
There was a problem hiding this comment.
Pull request overview
This PR replaces the futures crate dependency with the more lightweight futures-util crate, which provides only the utility types and traits without the full executor and macro machinery.
Key changes:
- Replaced
futuresdependency withfutures-utilinCargo.toml - Updated all import paths from
futures::tofutures_util::in source files - Updated documentation references to reflect the new crate name
- Modified doc examples in
mutexmodule to use project-specific imports
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cargo.toml | Replaced futures with futures-util dependency and updated feature flags |
| src/waker_slot.rs | Updated import paths and documentation to reference futures_util::task::AtomicWaker |
| src/mutex/mod.rs | Updated import paths to futures_util::future::FusedFuture and modified doc examples to use synchrony:: instead of futures::lock |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Actually, I think we can remove future-util dependency for mutex. We are only using FusedFuture, which is not necessary. |
Do you suggest that they should move to By the way, there's something very strange: |
|
@AsakuraMizu No, I mean we can completely get rid of futures in case of mutex |
No description provided.