Skip to content

feat: update compio#108

Merged
Berrysoft merged 2 commits into
masterfrom
update-compio
Apr 24, 2026
Merged

feat: update compio#108
Berrysoft merged 2 commits into
masterfrom
update-compio

Conversation

@Berrysoft
Copy link
Copy Markdown
Member

  • There's no spawn_unchecked. Have to work around.
  • Fix some warnings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace to a newer compio release candidate and adapts the GUI runtimes to the updated runtime APIs (notably removing reliance on spawn_unchecked), along with a few warning-cleanups.

Changes:

  • Bump compio (workspace) and related dev dependencies (cyper, cyper-axum) to newer RC versions.
  • Replace spawn_unchecked-based blocking logic with a new enter_block_on/main-task polling approach for Win32/WinUI runtimes.
  • Minor cleanup changes: example URLs updated; small refactors and float-literal suffixes to silence warnings.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Cargo.toml Bumps workspace compio version and removes compio-runtime from workspace deps.
winio/Cargo.toml Aligns winio’s dependency declarations with the workspace compio update and bumps dev deps (cyper*).
winio/examples/subviews/webview.rs Updates example URL.
winio/examples/subviews/net.rs Updates example URL.
winio-layout/src/stack_panel.rs Adds explicit f32 suffixes to avoid numeric-literal warnings.
winio-ui-winui/Cargo.toml Consolidates runtime-related deps into compio features (drops compio-runtime).
winio-ui-winui/src/runtime.rs Refactors block_on to use enter_block_on and exits app after future completes.
winio-ui-win32/src/runtime.rs Refactors block_on to use enter_block_on and quits message loop after future completes.
winio-ui-win32/src/ui/edit.rs Minor match-arm refactor.
winio-ui-windows-common/src/msgbox.rs Uses compio::runtime::ResumeUnwind helper for join error handling.
winio-ui-windows-common/src/filebox.rs Uses compio::runtime::ResumeUnwind helper for join error handling.
winio-ui-windows-common/src/darkmode/hook.rs Minor match-arm refactor.
winio-pollable/Cargo.toml Adjusts dependencies to support new main-task polling approach (futures-util, scoped-tls).
winio-pollable/src/lib.rs Implements main-task polling (enter_block_on) to replace spawn_unchecked patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread winio-pollable/src/lib.rs Outdated
Comment thread winio-pollable/src/lib.rs Outdated
Comment thread winio-pollable/src/lib.rs
Comment thread winio-pollable/src/lib.rs
Co-authored-by: Copilot <copilot@github.com>
@Berrysoft Berrysoft merged commit 5473c9e into master Apr 24, 2026
16 checks passed
@Berrysoft Berrysoft deleted the update-compio branch April 24, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants