feat: update compio#108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace to a newer compio release candidate and adapts the GUI runtimes to the updated runtime APIs (notably removing reliance on spawn_unchecked), along with a few warning-cleanups.
Changes:
- Bump
compio(workspace) and related dev dependencies (cyper,cyper-axum) to newer RC versions. - Replace
spawn_unchecked-based blocking logic with a newenter_block_on/main-task polling approach for Win32/WinUI runtimes. - Minor cleanup changes: example URLs updated; small refactors and float-literal suffixes to silence warnings.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Bumps workspace compio version and removes compio-runtime from workspace deps. |
winio/Cargo.toml |
Aligns winio’s dependency declarations with the workspace compio update and bumps dev deps (cyper*). |
winio/examples/subviews/webview.rs |
Updates example URL. |
winio/examples/subviews/net.rs |
Updates example URL. |
winio-layout/src/stack_panel.rs |
Adds explicit f32 suffixes to avoid numeric-literal warnings. |
winio-ui-winui/Cargo.toml |
Consolidates runtime-related deps into compio features (drops compio-runtime). |
winio-ui-winui/src/runtime.rs |
Refactors block_on to use enter_block_on and exits app after future completes. |
winio-ui-win32/src/runtime.rs |
Refactors block_on to use enter_block_on and quits message loop after future completes. |
winio-ui-win32/src/ui/edit.rs |
Minor match-arm refactor. |
winio-ui-windows-common/src/msgbox.rs |
Uses compio::runtime::ResumeUnwind helper for join error handling. |
winio-ui-windows-common/src/filebox.rs |
Uses compio::runtime::ResumeUnwind helper for join error handling. |
winio-ui-windows-common/src/darkmode/hook.rs |
Minor match-arm refactor. |
winio-pollable/Cargo.toml |
Adjusts dependencies to support new main-task polling approach (futures-util, scoped-tls). |
winio-pollable/src/lib.rs |
Implements main-task polling (enter_block_on) to replace spawn_unchecked patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawn_unchecked. Have to work around.