fix(win32): ignore ERROR_CLASS_ALREADY_EXISTS#37
Merged
Conversation
Berrysoft
force-pushed
the
fix/win32-class-conflict
branch
from
f7bbd11 to
8492dd9
Compare
Member
Author
|
Guard it behind a non-default feature, because I'm not sure about the consequences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
The window class we register has nothing special. If we ignore the conflict error, some others might register the window class before us. I don't know if it will cause an attack.
The window class name is changed (the old name contains some history of my code...) and appended with the crate version.