Patch #7
Open
Patch #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --replace flag works as intended on xfwm4.
the process name of gtk-window-decorator is gtk-window-deco, so when util.py tries to kill other decorators, it fails to kill gtk-window-decorator.
Now kills using the proc member of the decorators, rather than the base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed that changing to xfwm4 works perfectly fine with --replace (and more consistently).
killall is not recognized as a command without the psmisc package, so I changed it to pkill (which is in most systems)
I also added a proc member to the decorators on data.py for the process name, mostly because the process name of the GTK window decorator is gtk-window-deco, not gtk-window-decorator. Because of this, GTK would not be able to close when switching to a different decorator.