[codex] fix data indexing and clip metrics#28
Merged
Conversation
Member
Author
|
/gemini review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a narrower replacement for the useful parts of #23.
mainthat points installation atrequirements.txt.process-data.pyto write 0-based repeat indices into the schema consumed byRLHFDataset:extra_info["index"].torch.stack, preserving tensor dtype/device and computing the standard deviation over the response group.wfalls outside the clamp bounds instead of always reporting zero.Notes
The GRPO advantage change affects the training signal because it fixes the normalization used before policy loss computation.
The REINFORCE
pg_clipfrac/pg_clipfrac_lowerchange only affects logged metrics. It does not changeA,pg_losses, orpg_loss.Validation
python -m py_compile process-data.py verl/trainer/ppo/core_algos.pygit diff --checkuvx ruff check process-data.py verl/trainer/ppo/core_algos.pyNot run: full torch/pandas tests in this temporary checkout because the local Python environment lacks project dependencies such as
torchandpandas.