Skip to content

Check before removing self #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check before removing self #27

wants to merge 1 commit into from

Conversation

dy
Copy link
Member

@dy dy commented Jun 1, 2015

Needed for component/dialog#21

@dy dy mentioned this pull request Jun 1, 2015
Closed
@dy
Copy link
Member Author

dy commented Jun 4, 2015

@pirxpilot @jonathanong @juliangruber @rauchg
Can we make up a decision on that? For now hide raises an error on multiple call.

@pirxpilot
Copy link
Member

Shouldn't we check before hide does anything (like emitting hide) and we probably need an analogous check in show - so that show does not let's add similar check in show so that we don't emit 'show' event when overlay is already displayed.

@jonathanong
Copy link
Contributor

i have never used this so i'm abstaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dy @pirxpilot @jonathanong