test: migrate two suites to TestBalloon as a PoC - #101
Closed
wisemuji wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Wire the TestBalloon plugin into jindong-core and jindong-compose
alongside Kotest, and migrate exactly two suites to it:
- HapticIntensityTest: data-driven cases become one test per input via a
plain Kotlin loop, so each input is named and fails independently
(7 tests -> 14, same assertions).
- JindongApplierTest: the lateinit + beforeEach fixture is replaced by
testFixture { Fixture() } asContextForEach, making isolation
structural. Test bodies are unchanged apart from context -> testSuite.
Assertions stay on kotest-assertions-core in both; only the spec engine
changed. Every other suite is left on Kotest, which verifies the two
frameworks coexist in the same source set.
wisemuji
force-pushed
the
poc/testballoon-migration
branch
from
July 26, 2026 07:49
d5bd531 to
a4dfeab
Compare
Jindong Core Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100.
Migrates exactly two suites to TestBalloon and leaves every other suite on Kotest, so the diff doubles as the coexistence test.
HapticIntensityTest: data-driven cases were severalshouldBecalls in one test body, fail-fast and unnamed. A plain Kotlinforloop overtest(...)is all TestBalloon needs to give each input its own test -> 7 tests become 14, same assertions.JindongApplierTest: every test including nested suites gets a fresh fixture as its receiver. 22 tests before and after, bodies unchanged apart fromcontext→testSuite.Assertions stay on
kotest-assertions-core; only the spec engine changed.Tests
:jindong-core:testAndroidHostTest: The TestBalloon entry point contributes 14, the other 20 classes still run.apiCheckandspotlessCheckpass; no public API changes.