docs: formalize the reactive contract (trigger keys, frozen parameters, cancel-and-restart) - #98
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughChangesReactive contract and Clip DSL
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
l2hyunwoo
force-pushed
the
docs/reactive-contract
branch
from
July 9, 2026 15:10
7490a97 to
a24c1ff
Compare
l2hyunwoo
force-pushed
the
docs/reactive-contract
branch
from
July 21, 2026 05:23
a24c1ff to
0f50141
Compare
Jindong Core Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91.
Writes down what callers may rely on for reactive playback. Three rules, each checked against the runtime:
contentis frozen at compile time. The internal composition is composed once and disposed, so keys are the only recompile trigger.keyswhen its change should fire playback; state that only shapes the pattern stays insidecontent. A slider value passed as a key fires on every drag step.Vibrator.cancel()norCHHapticPatternPlayer.stopreports completion, so a few milliseconds of physical overlap are possible.Changes
JindongKDoc states the three rules and theJindong(pattern) { Clip(pattern) }idiom.reactive-contract.mdxand aClipDSL reference;quick-startalready covered reactive playback, so it links to the new guide rather than repeating it.Jindong(pattern, vararg keys)overload was considered and left out:Jindong(p) { ... }resolves to the existing vararg overload withpas a key, which compiles and plays the lambda instead of the pattern.Tests
Jindong-level contract oracle: a parameter change without a key does not re-fire; a key change re-fires with the current parameter value. Complements the Clip-level tests from #90.
Stacked on #90 (base branch
feat/clip-node).Summary by CodeRabbit
New Features
ClipDSL function for placing prebuilt haptic patterns on the timeline.Documentation
Clipand the Reactive Contract.Jindongdocumentation with examples, usage notes, and navigation links.Tests