Skip to content

Keep unreachable peer builds unknown - #158

Merged
myobie merged 1 commit into
mainfrom
fix/doctor-unknown-summary
Sep 4, 2026
Merged

Keep unreachable peer builds unknown#158
myobie merged 1 commit into
mainfrom
fix/doctor-unknown-summary

Conversation

@myobie

@myobie myobie commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Include unreachable peers in the build-agreement check.
  • Report every unverified peer build as unknown, including roaming peers.
  • Derive the closing summary as a testable value, so unknown results cannot print nothing to do.
  • Keep the existing build-risk explanation.

Red proof

Before the production change, both new unreachable-build tests failed. The build verdict was ok instead of unknown.

Verification

  • cargo test --lib doctor::tests — 22 passed
  • cargo test --lib — 469 passed, 4 ignored
  • cargo check --all-targets — passed
  • git diff --check — passed

No release or deployment is part of this pull request.

@myobie
myobie merged commit e7a038a into main Sep 4, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant