Make sync state ownership process-neutral - #159
Merged
Conversation
myobie
force-pushed
the
refactor/sync-process-neutral
branch
from
September 4, 2026 23:23
96f4cf2 to
3ca4e58
Compare
myobie
force-pushed
the
refactor/sync-process-neutral
branch
from
September 4, 2026 23:24
3ca4e58 to
4647dbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SyncEngineexplicit config and state paths instead of aFabricHome.SyncBook.fabric::synctarget.<state-root>/owner.lockfor the complete engine lifetime.Red proof
Before the production change, the new owner property reached and parsed deliberately corrupt state in a second engine. It failed because no owner lease existed.
After the change, the second engine fails on the owner lease before it reads state. Dropping the first engine releases the lease and permits a restart.
Verification
cargo check --all-targets— passedcargo test --lib— 471 passed, 4 ignoredgit diff --check— passedThis pull request changes no durable format and activates no companion path. Reverting it removes only the boundary and owner lease. No release or deployment is included.