Treat the transition companion absence as healthy - #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release A intentionally installs no fabric-sync binary or service. Doctor currently reports both absences as problems and tells the operator to run fabric service install.
This change recognizes the exact healthy transition: the main daemon answers, embedded sync owns the engine, and both the companion binary and service are absent. It reports the service and runtime as healthy and offers no action.
The paired states stay strict. A present companion binary without its service still requests service installation. An enabled service without its binary requests a matched pair. An unknown binary state stays unknown and offers no action.
The red test reproduced the deployed Release A report before the fix. Local proof passed 513 library tests, with five measurements ignored. The doctor integration target passed two tests. A read-only doctor run against the live Silber state reports both transition checks as healthy.