Report exec policy refusals honestly - #180
Merged
Merged
Conversation
myobie
force-pushed
the
fix/doctor-exec-refusal
branch
from
September 5, 2026 16:24
af7256b to
f15d795
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
fabric execnow reports every pre-command failure instead of returning silent status 1.execservice and return status 126.fabric doctorreports an intentional exec policy refusal asinfo, with no attention count.unknownand return status 3.Tests
cargo test --locked --libcargo test --locked --test doctorcargo test --locked --test local_slice exec_names_the_peer_and_service_when_the_peer_acl_refuses_itcargo test --locked --test shell trusted_peer_without_allow_shell_is_refusedgit diff --check