DIAGNOSTICS ONLY: issue 32 Linux failure receipt (do not merge) - #37
Closed
myobie wants to merge 2 commits into
Closed
DIAGNOSTICS ONLY: issue 32 Linux failure receipt (do not merge)#37myobie wants to merge 2 commits into
myobie wants to merge 2 commits into
Conversation
Do not merge. This is the fix branch's tests on top of the pre-fix teardown, so CI answers one question: does a_dropped_local_end_detaches_the_session_on_the_server_too actually catch the defect on Linux? macOS cannot answer it. macOS reads a dropped socket as a clean EOF and takes the branch that always worked, so the end-to-end test passes there either way. Only Linux takes the error branch. Expected: the unit test fails everywhere (it injects the ending directly), and the end-to-end server-detach test fails on Linux.
…ardown The shell version of the end-to-end test PASSED on Linux with the defect present (run 30862474787), so it guarded nothing. This carries the corrected quiet-tunnel version against the same pre-fix teardown. Expected: both the unit test AND the quiet-tunnel server-detach test now fail on Linux. If the quiet-tunnel test still passes, it is not a regression guard and I must say so rather than ship it as one.
Collaborator
Author
|
Receipt verified by cos: the failing Linux job shows the single targeted failure at tunnel.rs:2157, left None right Some(5), 193 passed 1 failed. The same tests are green on #38 with the fix. Purpose served; closing and deleting the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. Deliberately carries the PRE-FIX teardown with the new tests, so Linux CI answers whether those tests actually catch the defect.
macOS cannot answer it: it reads a dropped socket as a clean EOF and takes the branch that always worked. Only Linux takes the error branch.
Expected to FAIL. The real fix is in
fix/issue-32-abrupt-close-converges.